Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add boilerplate check #565

Merged
merged 2 commits into from
Jun 1, 2020
Merged

Add boilerplate check #565

merged 2 commits into from
Jun 1, 2020

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented May 27, 2020

Signed-off-by: yeya24 [email protected]

What problem does this PR solve?

Fixes #550

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2020

Codecov Report

Merging #565 into master will decrease coverage by 0.20%.
The diff coverage is 54.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #565      +/-   ##
==========================================
- Coverage   55.98%   55.78%   -0.21%     
==========================================
  Files          67       68       +1     
  Lines        4324     4383      +59     
==========================================
+ Hits         2421     2445      +24     
- Misses       1733     1768      +35     
  Partials      170      170              
Impacted Files Coverage Δ
api/v1alpha1/iochaos_types.go 40.00% <ø> (ø)
controllers/iochaos_controller.go 85.71% <ø> (ø)
pkg/chaosdaemon/time_server.go 88.23% <ø> (ø)
pkg/webhook/config/config.go 17.14% <ø> (ø)
pkg/utils/selector.go 52.24% <40.00%> (-0.24%) ⬇️
pkg/store/experiment/experiment.go 38.77% <45.23%> (ø)
controllers/twophase/types.go 55.88% <74.07%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87e8337...77c5897. Read the comment docs.

@yeya24 yeya24 force-pushed the add-checker branch 10 times, most recently from 3dd0e40 to a7bf542 Compare May 29, 2020 18:31
zhouqiang-cl
zhouqiang-cl previously approved these changes May 30, 2020
Copy link
Contributor

@zhouqiang-cl zhouqiang-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouqiang-cl
Copy link
Contributor

Seems CI broken

@zhouqiang-cl
Copy link
Contributor

/test

@zhouqiang-cl
Copy link
Contributor

/run-e2e-tests

@yeya24 yeya24 force-pushed the add-checker branch 2 times, most recently from 0b61968 to 39bad12 Compare May 30, 2020 15:25
@yeya24
Copy link
Contributor Author

yeya24 commented May 30, 2020

@zhouqiang-cl @cwen0 Please review. CI is green :)

zhouqiang-cl
zhouqiang-cl previously approved these changes May 30, 2020
Copy link
Contributor

@zhouqiang-cl zhouqiang-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cwen0
cwen0 previously approved these changes Jun 1, 2020
@cwen0
Copy link
Member

cwen0 commented Jun 1, 2020

@yeya24 Please fix conflicts! Thanks!

@yeya24 yeya24 dismissed stale reviews from cwen0 and zhouqiang-cl via 9096272 June 1, 2020 02:31
@yeya24 yeya24 force-pushed the add-checker branch 2 times, most recently from 9096272 to f884fa4 Compare June 1, 2020 02:51
Copy link
Contributor

@zhouqiang-cl zhouqiang-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouqiang-cl
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Jun 1, 2020

Your auto merge job has been accepted, waiting for:

  • 580

@sre-bot
Copy link
Contributor

sre-bot commented Jun 1, 2020

/run-all-tests

@sre-bot sre-bot merged commit f22ba60 into chaos-mesh:master Jun 1, 2020
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support licence check in CI
5 participants