Support updating chaos experiments by API #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cwen0 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #570 +/- ##
==========================================
- Coverage 55.98% 55.78% -0.21%
==========================================
Files 67 68 +1
Lines 4324 4383 +59
==========================================
+ Hits 2421 2445 +24
- Misses 1733 1768 +35
Partials 170 170
Continue to review full report at Codecov.
|
fewdan
reviewed
May 29, 2020
| f, ok := updateFuncs[exp.Target.Kind] | ||
| if !ok { | ||
| c.Status(http.StatusBadRequest) | ||
| _ = c.Error(utils.ErrInvalidRequest.New("Target kind is not available")) |
There was a problem hiding this comment.
How about changing to "_ = c.Error(utils.ErrInvalidRequest.New(exp.Target.Kind + " is not supported")) "?
| } | ||
|
|
||
| f, ok := createFuncs[exp.Target.Kind] | ||
| if !ok { | ||
| c.Status(http.StatusBadRequest) | ||
| _ = c.Error(utils.ErrInvalidRequest.New("Target kind is not available")) |
There was a problem hiding this comment.
How about changing to "_ = c.Error(utils.ErrInvalidRequest.New(exp.Target.Kind + " is not supported")) "?
Signed-off-by: cwen0 <[email protected]>
Signed-off-by: cwen0 <[email protected]>
yeya24
approved these changes
Jun 1, 2020
| }, | ||
| { | ||
| "Repository": "github.com/swaggo/swag", | ||
| "Commit": "eebe67fc31c39a02a763bcaa815baab805112cf3" |
|
/merge |
|
/run-all-tests |
|
@cwen0 merge failed. |
sjwsl
pushed a commit
to sjwsl/chaos-mesh
that referenced
this pull request
May 6, 2021
* update chaos experiments by API Signed-off-by: cwen0 <[email protected]> * address comments Signed-off-by: cwen0 <[email protected]> Co-authored-by: pingcap-github-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: cwen0 [email protected]
What problem does this PR solve?
#520
What is changed and how does it work?
Support updating chaos experiments by API
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: