-
Notifications
You must be signed in to change notification settings - Fork 850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: experiment creation #577
Conversation
target: API_URL, | ||
}) | ||
) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing semicolon.
createProxyMiddleware({ | ||
target: API_URL, | ||
}) | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing semicolon.
@@ -0,0 +1,12 @@ | |||
const { createProxyMiddleware } = require('http-proxy-middleware') | |||
|
|||
const API_URL = process.env.REACT_APP_API_URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
Missing semicolon.
@@ -0,0 +1,12 @@ | |||
const { createProxyMiddleware } = require('http-proxy-middleware') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
'destructuring binding' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
Missing semicolon.
Codecov Report
@@ Coverage Diff @@
## master #577 +/- ##
==========================================
- Coverage 55.98% 55.78% -0.21%
==========================================
Files 67 68 +1
Lines 4324 4383 +59
==========================================
+ Hits 2421 2445 +24
- Misses 1733 1768 +35
Partials 170 170
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
What problem does this PR solve?
This PR mainly handles the connection between the API and the front end.
What is changed and how does it work?
It brings a lot of changes.
Currently, the code I write supports two chaos creation processes,
NetWorkChaos
andPodChaos
. When the experiment creates successfully, the UI will redirect to theexperiments
page and show the latest changes.Does this PR introduce a user-facing change?
Yep, you can follow the readme file in the
ui
folder, start the dashboard to view.