Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: experiment creation #577

Merged
merged 10 commits into from
Jun 2, 2020
Merged

Conversation

g1eny0ung
Copy link
Member

What problem does this PR solve?

This PR mainly handles the connection between the API and the front end.

What is changed and how does it work?

It brings a lot of changes.

Currently, the code I write supports two chaos creation processes, NetWorkChaos and PodChaos. When the experiment creates successfully, the UI will redirect to the experiments page and show the latest changes.

Does this PR introduce a user-facing change?

Yep, you can follow the readme file in the ui folder, start the dashboard to view.

@g1eny0ung g1eny0ung requested review from xuechunL and cwen0 June 1, 2020 09:34
target: API_URL,
})
)
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon.

createProxyMiddleware({
target: API_URL,
})
)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon.

@@ -0,0 +1,12 @@
const { createProxyMiddleware } = require('http-proxy-middleware')

const API_URL = process.env.REACT_APP_API_URL
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
Missing semicolon.

@@ -0,0 +1,12 @@
const { createProxyMiddleware } = require('http-proxy-middleware')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
'destructuring binding' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
Missing semicolon.

@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2020

Codecov Report

Merging #577 into master will decrease coverage by 0.20%.
The diff coverage is 54.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #577      +/-   ##
==========================================
- Coverage   55.98%   55.78%   -0.21%     
==========================================
  Files          67       68       +1     
  Lines        4324     4383      +59     
==========================================
+ Hits         2421     2445      +24     
- Misses       1733     1768      +35     
  Partials      170      170              
Impacted Files Coverage Δ
api/v1alpha1/iochaos_types.go 40.00% <ø> (ø)
controllers/iochaos_controller.go 85.71% <ø> (ø)
pkg/chaosdaemon/time_server.go 88.23% <ø> (ø)
pkg/webhook/config/config.go 17.14% <ø> (ø)
pkg/utils/selector.go 52.24% <40.00%> (-0.24%) ⬇️
pkg/store/experiment/experiment.go 38.77% <45.23%> (ø)
controllers/twophase/types.go 55.88% <74.07%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 432cb53...e053f2b. Read the comment docs.

xuechunL
xuechunL previously approved these changes Jun 1, 2020
Copy link
Contributor

@xuechunL xuechunL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zhouqiang-cl zhouqiang-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member

cwen0 commented Jun 2, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Jun 2, 2020

/run-all-tests

@sre-bot sre-bot merged commit 3be4666 into chaos-mesh:master Jun 2, 2020
@g1eny0ung g1eny0ung deleted the feat/experiments branch June 11, 2020 09:21
@dcalvin dcalvin mentioned this pull request Feb 5, 2021
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants