Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only schedule mode in pod(container)-kill #597

Merged
merged 7 commits into from
Jun 8, 2020

Conversation

g1eny0ung
Copy link
Member

What problem does this PR solve?

This PR solves #596.

@g1eny0ung g1eny0ung requested review from cwen0 and yeya24 June 5, 2020 03:32
@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2020

Codecov Report

Merging #597 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #597   +/-   ##
=======================================
  Coverage   55.78%   55.78%           
=======================================
  Files          68       68           
  Lines        4383     4383           
=======================================
  Hits         2445     2445           
  Misses       1768     1768           
  Partials      170      170           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65ca6b9...dcbbfa1. Read the comment docs.

@g1eny0ung g1eny0ung added the type/bug-fix Fix for a previously reported bug. label Jun 5, 2020
ui/src/lib/formikhelpers.ts Show resolved Hide resolved
@yeya24
Copy link
Contributor

yeya24 commented Jun 5, 2020

Hey, @g1eny0ung I test this feature locally. But seems there is another problem.

After I click NetworkChaos and enter something, then I switch back to PodChaos. Then I cannot select any actions in the SelectField. Is it related to your change?

Screenshot from 2020-06-05 07-56-15

@g1eny0ung
Copy link
Member Author

@yeya24 I follow your description and test several times. It's ok for me to begin switching to NetworkChaos, select an action and type something and then switch to PodChaos and select an action.

@yeya24
Copy link
Contributor

yeya24 commented Jun 5, 2020

@yeya24 I follow your description and test several times. It's ok for me to begin switching to NetworkChaos, select an action and type something and then switch to PodChaos and select an action.

Would you minding holding this PR today? I will try to provide detailed reproduce procedures.

@g1eny0ung
Copy link
Member Author

@yeya24 I follow your description and test several times. It's ok for me to begin switching to NetworkChaos, select an action and type something and then switch to PodChaos and select an action.

Would you minding holding this PR today? I will try to provide detailed reproduce procedures.

Yep. It's ok for me.

@yeya24
Copy link
Contributor

yeya24 commented Jun 5, 2020

@yeya24 I follow your description and test several times. It's ok for me to begin switching to NetworkChaos, select an action and type something and then switch to PodChaos and select an action.

Would you minding holding this PR today? I will try to provide detailed reproduce procedures.

Yep. It's ok for me.

The steps are:

  1. Select NetworkChaos and Delay, enter 1s and click Next
  2. Go back to the Target page and try to select actions.
  3. You will find you can select actions but you cannot see anything in the SelectField.

But it is weird that when I go back to the Target page, and click Pod Lifecycle, then I can choose actions. If not click, then it will reproduce this problem. Is this expected?

@g1eny0ung
Copy link
Member Author

@yeya24 I follow your description and test several times. It's ok for me to begin switching to NetworkChaos, select an action and type something and then switch to PodChaos and select an action.

Would you minding holding this PR today? I will try to provide detailed reproduce procedures.

Yep. It's ok for me.

The steps are:

  1. Select NetworkChaos and Delay, enter 1s and click Next
  2. Go back to the Target page and try to select actions.
  3. You will find you can select actions but you cannot see anything in the SelectField.

But it is weird that when I go back to the Target page, and click Pod Lifecycle, then I can choose actions. If not click, then it will reproduce this problem. Is this expected?

Know about this problem. The reason is I will set the Chaos kind when clicking the left vertical tabs. If click next in target form and then back, the Chaos kind will not be updated except you click the tabs again. I will fix it soon.

@g1eny0ung
Copy link
Member Author

@yeya24 Now the problem of selection should be solved.

And also, the target form will remember the last changes when you switch back to it.

Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Tested locally and it works well.

Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member

cwen0 commented Jun 8, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Jun 8, 2020

/run-all-tests

@sre-bot sre-bot merged commit c7003eb into chaos-mesh:master Jun 8, 2020
@g1eny0ung g1eny0ung deleted the fix/cron-job-problem branch June 8, 2020 03:06
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
* fix: only schedule mode in pod(container)-kill

* chore: update README

* fix: reset other chaos after select action

* fix: correct chaos kind selection

Co-authored-by: pingcap-github-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge type/bug-fix Fix for a previously reported bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants