-
Notifications
You must be signed in to change notification settings - Fork 850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: only schedule mode in pod(container)-kill #597
Conversation
Codecov Report
@@ Coverage Diff @@
## master #597 +/- ##
=======================================
Coverage 55.78% 55.78%
=======================================
Files 68 68
Lines 4383 4383
=======================================
Hits 2445 2445
Misses 1768 1768
Partials 170 170 Continue to review full report at Codecov.
|
Hey, @g1eny0ung I test this feature locally. But seems there is another problem. After I click NetworkChaos and enter something, then I switch back to PodChaos. Then I cannot select any actions in the |
@yeya24 I follow your description and test several times. It's ok for me to begin switching to |
Would you minding holding this PR today? I will try to provide detailed reproduce procedures. |
Yep. It's ok for me. |
The steps are:
But it is weird that when I go back to the |
Know about this problem. The reason is I will set the |
@yeya24 Now the problem of selection should be solved. And also, the target form will remember the last changes when you switch back to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Tested locally and it works well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
* fix: only schedule mode in pod(container)-kill * chore: update README * fix: reset other chaos after select action * fix: correct chaos kind selection Co-authored-by: pingcap-github-bot <[email protected]>
What problem does this PR solve?
This PR solves #596.