Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update make ensure-all in setup_env.md #607

Merged
merged 2 commits into from
Jun 9, 2020

Conversation

shonge
Copy link
Contributor

@shonge shonge commented Jun 9, 2020

What problem does this PR solve?

Update setup_env.md

What is changed and how does it work?

Replace legacy make install-kustomize and make install-kubebuilder to make ensure-all

Check List

Tests

  • No code

Code changes

Side effects

  • Breaking backward compatibility

Related changes

  • Need to update the documentation

Does this PR introduce a user-facing change?:

NONE

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2020

Codecov Report

Merging #607 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #607   +/-   ##
=======================================
  Coverage   55.78%   55.78%           
=======================================
  Files          68       68           
  Lines        4383     4383           
=======================================
  Hits         2445     2445           
  Misses       1768     1768           
  Partials      170      170           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 441f1e2...8894f02. Read the comment docs.

@cwen0 cwen0 added the documentation Improvements or additions to documentation label Jun 9, 2020
@fewdan
Copy link
Member

fewdan commented Jun 9, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Jun 9, 2020

Your auto merge job has been accepted, waiting for:

  • 603

@sre-bot
Copy link
Contributor

sre-bot commented Jun 9, 2020

/run-all-tests

@sre-bot sre-bot merged commit f55de78 into chaos-mesh:master Jun 9, 2020
@shonge shonge deleted the update_setup_doc branch June 9, 2020 12:44
shonge added a commit to shonge/chaos-mesh that referenced this pull request Jul 7, 2020
Co-authored-by: pingcap-github-bot <[email protected]>
Signed-off-by: shonge <[email protected]>
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation status/can-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants