[add] add uid in events and archive_experiments

[fewdan]

What problem does this PR solve?

add uid in events and archive_experiments

What is changed and how does it work?

add uid in events and archive_experiments

Check List

Tests

• No code

Code changes

• Has Go code change

Side effects

• NO

Related changes

• NO

Does this PR introduce a user-facing change?

NONE

[codecov-commenter]

Codecov Report

Merging #623 into master will decrease coverage by 0.17%.
The diff coverage is 21.05%.

@@            Coverage Diff             @@
##           master     #623      +/-   ##
==========================================
- Coverage   55.78%   55.61%   -0.18%     
==========================================
  Files          68       68              
  Lines        4383     4393      +10     
==========================================
- Hits         2445     2443       -2     
- Misses       1768     1779      +11     
- Partials      170      171       +1     

Impacted Files	Coverage Δ
controllers/networkchaos/ipset/ipset.go	37.14% <0.00%> (ø)
pkg/store/experiment/experiment.go	32.20% <0.00%> (-6.58%)	⬇️
pkg/utils/chaosdaemon.go	51.21% <0.00%> (ø)
pkg/utils/grpc.go	0.00% <0.00%> (ø)
controllers/networkchaos/netem/types.go	47.27% <50.00%> (ø)
controllers/podchaos/containerkill/types.go	64.38% <100.00%> (ø)
controllers/timechaos/types.go	61.44% <100.00%> (ø)
pkg/utils/selector.go	51.42% <0.00%> (-0.82%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7aaceb...87c59f7. Read the comment docs.

[yeya24]

Can I ask what this UID for? Do you want to connect the chaos object in Kubernetes with the event in DB? Could you please introduce some use cases?

[fewdan]

Can I ask what this UID for? Do you want to connect the chaos object in Kubernetes with the event in DB? Could you please introduce some use cases?

@yeya24
There is a problem that if chaos with the same name is deleted and then created, it cannot be distinguished in db.
So if uid is introduced, you can distinguish chaos with the same name (because their uid is different). In this case, only need to modify the API, without modifying other parts of chaos-mesh, can meet the requirements.

[yeya24]

Can I ask what this UID for? Do you want to connect the chaos object in Kubernetes with the event in DB? Could you please introduce some use cases?

@yeya24
There is a problem that if chaos with the same name is deleted and then created, it cannot be distinguished in db.
So if uid is introduced, you can distinguish chaos with the same name (because their uid is different). In this case, only need to modify the API, without modifying other parts of chaos-mesh, can meet the requirements.

Got it. I can understand that this field is used to differentiate different chaos but with the same name.

But from #608 (comment), if we plan to add unique suffix to chaos name, then is it still necessary to have the UID?

[fewdan]

@yeya24
We have discussed, and the conclusion is that there are some shortcomings in adding a suffix, so we decided to use UID+name+NS+kind to distinguish different chaos.
The disadvantages of adding a suffix are:

1. The name is changed, it is inconvenient for the user to edit or delete chaos.
2. The user cannot operate by "kubectl delete -f xxx.yaml".

If you use UID, you only need to modify the chaos-dashboard part to meet the user's requirements, and it is more reasonable.
So after this PR merge, I will modify other APIs.

[cwen0]

Rest LGTM

[cwen0]

LGTM

[fewdan]

/merge

[ti-srebot]

/run-all-tests