Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[add] common/labels #630

Merged
merged 1 commit into from
Jun 17, 2020
Merged

[add] common/labels #630

merged 1 commit into from
Jun 17, 2020

Conversation

fewdan
Copy link
Member

@fewdan fewdan commented Jun 16, 2020

What problem does this PR solve?

add common/labels

What is changed and how does it work?

add common/labels

Check List

Tests

  • No code

Code changes

  • Has Go code change

Side effects

  • NO

Related changes

  • NO

Does this PR introduce a user-facing change?

NONE

@codecov-commenter
Copy link

Codecov Report

Merging #630 into master will decrease coverage by 0.21%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #630      +/-   ##
==========================================
- Coverage   55.78%   55.57%   -0.22%     
==========================================
  Files          68       68              
  Lines        4383     4398      +15     
==========================================
- Hits         2445     2444       -1     
- Misses       1768     1783      +15     
- Partials      170      171       +1     
Impacted Files Coverage Δ
controllers/networkchaos/ipset/ipset.go 37.14% <0.00%> (ø)
pkg/store/experiment/experiment.go 32.20% <0.00%> (-6.58%) ⬇️
pkg/utils/chaosdaemon.go 51.21% <0.00%> (ø)
pkg/utils/grpc.go 0.00% <0.00%> (ø)
controllers/twophase/types.go 54.20% <33.33%> (-1.68%) ⬇️
controllers/networkchaos/netem/types.go 47.27% <50.00%> (ø)
controllers/podchaos/containerkill/types.go 64.38% <100.00%> (ø)
controllers/timechaos/types.go 61.44% <100.00%> (ø)
pkg/utils/selector.go 51.42% <0.00%> (-0.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eb8d81...4bcd37a. Read the comment docs.

@fewdan fewdan requested review from cwen0, Yisaer, yeya24 and Gallardot June 16, 2020 10:08
Copy link
Contributor

@zhouqiang-cl zhouqiang-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yisaer
Copy link
Contributor

Yisaer commented Jun 17, 2020

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@fewdan merge failed.

@cwen0 cwen0 merged commit 5dd0b86 into chaos-mesh:master Jun 17, 2020
shonge pushed a commit to shonge/chaos-mesh that referenced this pull request Jul 7, 2020
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API] Support get all labels of the special pods
6 participants