Add flag to install dependency only #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cwen0 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #631 +/- ##
==========================================
- Coverage 55.78% 55.61% -0.17%
==========================================
Files 68 68
Lines 4383 4398 +15
==========================================
+ Hits 2445 2446 +1
- Misses 1768 1782 +14
Partials 170 170
Continue to review full report at Codecov.
|
Yisaer
reviewed
Jun 17, 2020
helm/chaos-mesh/values.yaml
Outdated
| @@ -21,7 +21,7 @@ controllerManager: | |||
| replicaCount: 1 | |||
|
|
|||
| image: pingcap/chaos-mesh:latest | |||
| imagePullPolicy: Always | |||
| imagePullPolicy: IfNotPresent | |||
There was a problem hiding this comment.
I think always is not necessary. Sometimes if the pod was restarted and we change some flags of it, which may cause the pod crashing.
There was a problem hiding this comment.
I think we should keep it set to always. Because our image is latest. Unless we specify a particular version.
Signed-off-by: cwen0 <[email protected]>
Yisaer
approved these changes
Jun 17, 2020
Gallardot
approved these changes
Jun 17, 2020
shonge
pushed a commit
to shonge/chaos-mesh
that referenced
this pull request
Jul 7, 2020
* add flag to install dependency only Signed-off-by: cwen0 <[email protected]> * address comments Signed-off-by: cwen0 <[email protected]> Signed-off-by: shonge <[email protected]>
sjwsl
pushed a commit
to sjwsl/chaos-mesh
that referenced
this pull request
May 6, 2021
* add flag to install dependency only Signed-off-by: cwen0 <[email protected]> * address comments Signed-off-by: cwen0 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: cwen0 [email protected]
What problem does this PR solve?
install.shIfNotPresentinstead ofAlways