Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[add] add api/common/annotations and update api/common/labels #634

Merged
merged 8 commits into from
Jun 22, 2020
Merged

[add] add api/common/annotations and update api/common/labels #634

merged 8 commits into from
Jun 22, 2020

Conversation

fewdan
Copy link
Member

@fewdan fewdan commented Jun 17, 2020

What problem does this PR solve?

add api/common/annotations and update api/common/labels

What is changed and how does it work?

add api/common/annotations and update api/common/labels

Check List

Tests

  • No code

Code changes

  • Has Go code change

Side effects

  • NO

Related changes

  • NO

Does this PR introduce a user-facing change?

NONE

image

@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2020

Codecov Report

Merging #634 into master will decrease coverage by 0.16%.
The diff coverage is 27.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #634      +/-   ##
==========================================
- Coverage   55.78%   55.61%   -0.17%     
==========================================
  Files          68       68              
  Lines        4383     4398      +15     
==========================================
+ Hits         2445     2446       +1     
- Misses       1768     1782      +14     
  Partials      170      170              
Impacted Files Coverage Δ
controllers/networkchaos/ipset/ipset.go 37.14% <0.00%> (ø)
pkg/store/experiment/experiment.go 32.20% <0.00%> (-6.58%) ⬇️
pkg/utils/chaosdaemon.go 51.21% <0.00%> (ø)
pkg/utils/grpc.go 0.00% <0.00%> (ø)
controllers/twophase/types.go 54.20% <40.00%> (-1.68%) ⬇️
controllers/networkchaos/netem/types.go 47.27% <50.00%> (ø)
controllers/podchaos/containerkill/types.go 64.38% <100.00%> (ø)
controllers/timechaos/types.go 61.44% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a01a5d...dde3d0d. Read the comment docs.

@fewdan fewdan changed the title [update] api/common/labels [add] add api/common/annotations and update api/common/labels Jun 17, 2020
@cwen0
Copy link
Member

cwen0 commented Jun 19, 2020

@fewdan You can run make tidy to fix CI.

pkg/apiserver/common/common.go Outdated Show resolved Hide resolved
pkg/apiserver/common/common.go Outdated Show resolved Hide resolved
pkg/apiserver/common/common.go Outdated Show resolved Hide resolved
pkg/apiserver/common/common.go Outdated Show resolved Hide resolved
@fewdan fewdan requested a review from cwen0 June 20, 2020 08:25
Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CLAassistant
Copy link

CLAassistant commented Jun 22, 2020

CLA assistant check
All committers have signed the CLA.

@g1eny0ung g1eny0ung self-requested a review June 22, 2020 03:52
Copy link
Member

@g1eny0ung g1eny0ung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cwen0 cwen0 merged commit 38fabf0 into chaos-mesh:master Jun 22, 2020
@fewdan fewdan deleted the labels branch July 2, 2020 07:58
shonge pushed a commit to shonge/chaos-mesh that referenced this pull request Jul 7, 2020
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants