api-server: add the fallback page #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cwen0 <[email protected]>
Signed-off-by: cwen0 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #640 +/- ##
==========================================
- Coverage 55.78% 55.61% -0.17%
==========================================
Files 68 68
Lines 4383 4398 +15
==========================================
+ Hits 2445 2446 +1
- Misses 1768 1782 +14
Partials 170 170
Continue to review full report at Codecov.
|
yeya24
approved these changes
Jun 18, 2020
| @@ -18,7 +18,7 @@ import ( | |||
| "net/http" | |||
| "os" | |||
|
|
|||
| "github.com/shurcooL/vfsgen" | |||
| "github.com/cwen0/vfsgen" | |||
There was a problem hiding this comment.
Is this change intended? You'd like to use own fork here?
There was a problem hiding this comment.
The origin repo doesn't support setting the fallback and the repo is rarely updated, but we need this feature. cwen0/vfsgen@c353227
There was a problem hiding this comment.
I will try to push this pr to the origin repo.
|
/merge |
|
/run-all-tests |
shonge
pushed a commit
to shonge/chaos-mesh
that referenced
this pull request
Jul 7, 2020
* api-server: add fallback Signed-off-by: cwen0 <[email protected]> * make clean Signed-off-by: cwen0 <[email protected]> Signed-off-by: shonge <[email protected]>
sjwsl
pushed a commit
to sjwsl/chaos-mesh
that referenced
this pull request
May 6, 2021
* api-server: add fallback Signed-off-by: cwen0 <[email protected]> * make clean Signed-off-by: cwen0 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: cwen0 [email protected]
What problem does this PR solve?
index.htmlas the fallback page