Store experiment when it was created

[cwen0]

Signed-off-by: cwen0 [email protected]

What problem does this PR solve?

Fix #657 #557

What is changed and how does it work?

• store experiment when it was created
• add archived field to archive_eperiment struct, when some experiment was deleted and update archived to true

[codecov-commenter]

Codecov Report

Merging #662 into master will decrease coverage by 1.12%.
The diff coverage is 31.06%.

@@            Coverage Diff             @@
##           master     #662      +/-   ##
==========================================
- Coverage   55.78%   54.65%   -1.13%     
==========================================
  Files          68       68              
  Lines        4383     4574     +191     
==========================================
+ Hits         2445     2500      +55     
- Misses       1768     1887     +119     
- Partials      170      187      +17     

Impacted Files	Coverage Δ
api/v1alpha1/podchaos_types.go	37.14% <ø> (ø)
controllers/networkchaos/ipset/ipset.go	37.14% <0.00%> (ø)
pkg/utils/chaosdaemon.go	51.21% <0.00%> (ø)
pkg/utils/grpc.go	0.00% <0.00%> (ø)
pkg/webhook/inject/inject.go	73.49% <0.00%> (-0.68%)	⬇️
pkg/store/experiment/experiment.go	23.14% <9.72%> (-15.63%)	⬇️
pkg/httpfs/fs.go	31.48% <31.48%> (ø)
controllers/twophase/types.go	54.20% <40.00%> (-1.68%)	⬇️
controllers/networkchaos/netem/types.go	47.27% <50.00%> (ø)
pkg/utils/selector.go	53.15% <66.66%> (+0.91%)	⬆️
... and 5 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f39a01c...884dbbc. Read the comment docs.

[yeya24]

TBH I don't think it is a good choice. The experiment object can be updated/changed after it is created. Then do we want to update the archive experiment in db every time?

[cwen0]

TBH I don't think it is a good choice. The experiment object can be updated/changed after it is created. Then do we want to update the archive experiment in db every time?

Yes, I think updating it in DB every time is ok. 😂， I don't want to use finalizers any more.

[fewdan]

LGTM

[ti-srebot]

@fewdan, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader.

[cwen0]

@YangKeao @yeya24 PTAL, thanks!

[ti-srebot]

@g1eny0ung, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader for the related sigs:chaos-mesh(slack).

[fewdan]

/merge

[ti-srebot]

/run-all-tests

[ti-srebot]

@cwen0 merge failed.