add grace period for pod kill chaos #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #663 +/- ##
==========================================
- Coverage 55.78% 55.69% -0.09%
==========================================
Files 68 67 -1
Lines 4383 4417 +34
==========================================
+ Hits 2445 2460 +15
- Misses 1768 1782 +14
- Partials 170 175 +5
Continue to review full report at Codecov.
|
|
@namco1992 Thanks for your contribution! Can you fix |
namco1992
force-pushed
the
pod-kill-grace-period
branch
from
272d60b to
98a2df9
Compare
Signed-off-by: Gong Mengnan <[email protected]>
namco1992
force-pushed
the
pod-kill-grace-period
branch
from
98a2df9 to
bba3bca
Compare
|
@cwen0 Fixed, thanks! |
|
/run-e2e-tests |
fewdan
approved these changes
Jul 1, 2020
|
/merge |
|
/run-all-tests |
|
@namco1992 merge failed. |
|
/run-all-tests |
lilin90
pushed a commit
to lilin90/chaos-mesh
that referenced
this pull request
Jul 1, 2020
Signed-off-by: Gong Mengnan <[email protected]>Signed-off-by: lilin90 <[email protected]>
shonge
pushed a commit
to shonge/chaos-mesh
that referenced
this pull request
Jul 7, 2020
Signed-off-by: Gong Mengnan <[email protected]> Signed-off-by: shonge <[email protected]>
sjwsl
pushed a commit
to sjwsl/chaos-mesh
that referenced
this pull request
May 6, 2021
Signed-off-by: Gong Mengnan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Solve #569.
What is changed and how does it work?
Added a
gracePeriodfield in thePodChaosCRD.Check List
Tests
Code changes
Related changes
gracePeriodfield.Does this PR introduce a user-facing change?