Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: big changes of dashboard #665

Merged
merged 26 commits into from
Jul 2, 2020

Conversation

g1eny0ung
Copy link
Member

@g1eny0ung g1eny0ung commented Jun 30, 2020

Signed-off-by: Yue Yang [email protected]

What problem does this PR solve?

First, sorry this PR is relatively huge, I'm a little busy last past days, so I didn't split it into several little PRs.

This PR aims to give the dashboard an overall optimization.

What is changed and how does it work?

  • A concise interface

  • Now can create an experiment from YAML file

  • Make label_selectors as a HTML select element

  • Now can search events

    Also, you can search by some useful patterns, for example:
    namespace:default network-delay-exmaple will search events with namespace default.
    kind:NetworkChaos network-delay-exmaple will search events with kind NetworkChaos, you can also type kind:net, it will also work because the search is fuzzy.
    time:2020-06-30 network-delay-exmaple will search events before 2020-06-30, the time pattern only supports year, month, and day.

  • Click timeline legends will zoom to the last event position by experiment name

  • Init archives page

  • update .ico files to adapt dark mode

@g1eny0ung g1eny0ung requested review from fewdan, cwen0 and yeya24 June 30, 2020 07:40
@CLAassistant
Copy link

CLAassistant commented Jun 30, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2020

Codecov Report

Merging #665 into master will decrease coverage by 0.01%.
The diff coverage is 38.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #665      +/-   ##
==========================================
- Coverage   55.78%   55.76%   -0.02%     
==========================================
  Files          68       68              
  Lines        4383     4397      +14     
==========================================
+ Hits         2445     2452       +7     
- Misses       1768     1775       +7     
  Partials      170      170              
Impacted Files Coverage Δ
controllers/networkchaos/ipset/ipset.go 37.14% <0.00%> (ø)
pkg/store/experiment/experiment.go 32.20% <0.00%> (-6.58%) ⬇️
pkg/utils/chaosdaemon.go 51.21% <0.00%> (ø)
pkg/utils/grpc.go 0.00% <0.00%> (ø)
controllers/twophase/types.go 54.20% <40.00%> (-1.68%) ⬇️
controllers/networkchaos/netem/types.go 47.27% <50.00%> (ø)
controllers/podchaos/containerkill/types.go 64.38% <100.00%> (ø)
controllers/timechaos/types.go 61.44% <100.00%> (ø)
pkg/webhook/config/watcher/config.go 100.00% <100.00%> (+58.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 699993e...cb6fb23. Read the comment docs.

@yeya24
Copy link
Contributor

yeya24 commented Jun 30, 2020

Could you please sign the DCO?

And after I deployed one experiment, the frontend crashed. Can you take a look?
Screenshot from 2020-06-30 14-05-05

@g1eny0ung
Copy link
Member Author

Could you please sign the DCO?

And after I deployed one experiment, the frontend crashed. Can you take a look?
Screenshot from 2020-06-30 14-05-05

After debugging, I found this should be the case where I did not handle the experimental error correctly. I will fix it soon.

@g1eny0ung g1eny0ung force-pushed the refactor/experiments branch 4 times, most recently from 1463e82 to fa8962d Compare July 1, 2020 06:08
@g1eny0ung
Copy link
Member Author

@yeya24 The crash problem should be fixed.

And I try to rebase git to add the sign-off, but the hard is I'm already merging the upstream update twice, so it's complicated to add it to every single commit pushed by me. 😵

What about adding the sign-off before this PR ready to merge to master? This can save a lot of time. I will remember to sign it in the later PRs.

@cwen0
Copy link
Member

cwen0 commented Jul 1, 2020

image

@cwen0
Copy link
Member

cwen0 commented Jul 1, 2020

Can we add a delete button on the label selector?
image

@g1eny0ung
Copy link
Member Author

@cwen0 The legends problem should be fixed and also, now you can easily delete the labels.

yeya24
yeya24 previously approved these changes Jul 1, 2020
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good now. Awesome work!

Just one small nit I think, can we sort the experiments by created time? Or this could be handled at backend as well

Screenshot from 2020-07-01 10-48-50

@g1eny0ung
Copy link
Member Author

@yeya24 Thx.~ 😆

Generally speaking, this is usually handled in the front-end. I will think about how to implement it. At present, the feature of the search experiment has not been completed. I can put the sorting into the search and complete it together.

cwen0
cwen0 previously approved these changes Jul 2, 2020
@g1eny0ung g1eny0ung dismissed stale reviews from cwen0 and yeya24 via a45b2f7 July 2, 2020 02:22
@g1eny0ung g1eny0ung force-pushed the refactor/experiments branch 4 times, most recently from d44a8a7 to cb6fb23 Compare July 2, 2020 02:36
@cwen0 cwen0 merged commit a62fec4 into chaos-mesh:master Jul 2, 2020
@g1eny0ung g1eny0ung deleted the refactor/experiments branch July 2, 2020 02:45
shonge pushed a commit to shonge/chaos-mesh that referenced this pull request Jul 7, 2020
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants