Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update description, link, and fix format #670

Merged
merged 2 commits into from
Jul 2, 2020
Merged

Update description, link, and fix format #670

merged 2 commits into from
Jul 2, 2020

Conversation

lilin90
Copy link
Member

@lilin90 lilin90 commented Jul 1, 2020 •
edited
Loading

What problem does this PR solve?

  • Update descriptions and Slack channel link inREADME.md
  • Fix the list format that causes a display error (step number and indentation) in CONTRIBUTING.md
  • Make wording style consistent

What is changed and how does it work?

Update wording and format

Check List

Tests

  • No code

Does this PR introduce a user-facing change?

NONE

@lilin90 lilin90 marked this pull request as ready for review July 1, 2020 12:45
@lilin90 lilin90 requested review from cwen0 and dcalvin and removed request for cwen0 July 1, 2020 12:45
dcalvin
dcalvin approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@dcalvin dcalvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 mentioned this pull request Jul 1, 2020
Closed
@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2020 •
edited
Loading

Codecov Report

Merging #670 into master will decrease coverage by 0.66%.
The diff coverage is 38.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #670      +/-   ##
==========================================
- Coverage   55.78%   55.11%   -0.67%     
==========================================
  Files          68       68              
  Lines        4383     4525     +142     
==========================================
+ Hits         2445     2494      +49     
- Misses       1768     1844      +76     
- Partials      170      187      +17
Impacted Files Coverage Δ
api/v1alpha1/podchaos_types.go 37.14% <ø> (ø)
controllers/networkchaos/ipset/ipset.go 37.14% <0.00%> (ø)
pkg/store/experiment/experiment.go 32.20% <0.00%> (-6.58%) ⬇️
pkg/utils/chaosdaemon.go 51.21% <0.00%> (ø)
pkg/utils/grpc.go 0.00% <0.00%> (ø)
pkg/webhook/inject/inject.go 73.49% <0.00%> (-0.68%) ⬇️
pkg/httpfs/fs.go 31.48% <31.48%> (ø)
controllers/twophase/types.go 54.20% <40.00%> (-1.68%) ⬇️
controllers/networkchaos/netem/types.go 47.27% <50.00%> (ø)
pkg/utils/selector.go 53.15% <66.66%> (+0.91%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6cfa65...ed1d166. Read the comment docs.

zhouqiang-cl
zhouqiang-cl approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@zhouqiang-cl zhouqiang-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member

cwen0 commented Jul 2, 2020

/merge

@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 656

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 16ef2aa into chaos-mesh:master Jul 2, 2020
@lilin90 lilin90 deleted the update-wording-format branch July 2, 2020 02:44
shonge pushed a commit to shonge/chaos-mesh that referenced this pull request Jul 7, 2020
@lilin90 @ti-srebot @shonge
Update description, link, and fix format (chaos-mesh#670)
eaa53a9 
Signed-off-by: lilin90 <[email protected]>

Co-authored-by: ti-srebot <[email protected]>
Signed-off-by: shonge <[email protected]>
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
@lilin90 @ti-srebot
Update description, link, and fix format (chaos-mesh#670)
0da694f 
Signed-off-by: lilin90 <[email protected]>

Co-authored-by: ti-srebot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhouqiang-cl zhouqiang-cl zhouqiang-cl approved these changes

@dcalvin dcalvin dcalvin approved these changes

@cwen0 cwen0 Awaiting requested review from cwen0

Assignees
No one assigned
Labels
difficulty/easy status/can-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lilin90 @codecov-commenter @cwen0 @ti-srebot @dcalvin @zhouqiang-cl