Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stress-ng to target pid namespace #685

Merged
merged 15 commits into from
Jul 13, 2020

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Jul 9, 2020

What problem does this PR solve?

With this PR, users can see stress-ng process in corresponding pod. This PR also uses a util-linux version of nsenter rather than busybox's one. The util-linux's nsenter is more stable and seems to have less bugs.

What is changed and how does it work?

Check List

Tests

  • Manual test

Code changes

  • Has Go code change
NONE

@YangKeao YangKeao changed the title Add stress to pid namespace Add stress-ng to target pid namespace Jul 9, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2020

Codecov Report

Merging #685 into master will decrease coverage by 1.47%.
The diff coverage is 28.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #685      +/-   ##
==========================================
- Coverage   55.78%   54.30%   -1.48%     
==========================================
  Files          68       68              
  Lines        4383     4600     +217     
==========================================
+ Hits         2445     2498      +53     
- Misses       1768     1914     +146     
- Partials      170      188      +18     
Impacted Files Coverage Δ
api/v1alpha1/podchaos_types.go 37.14% <ø> (ø)
controllers/networkchaos/ipset/ipset.go 37.14% <0.00%> (ø)
pkg/chaosdaemon/netlink_linux.go 0.00% <0.00%> (ø)
pkg/chaosdaemon/stress_server_linux.go 0.00% <0.00%> (ø)
pkg/chaosdaemon/tc_linux.go 42.85% <0.00%> (ø)
pkg/utils/chaosdaemon.go 51.21% <0.00%> (ø)
pkg/utils/grpc.go 0.00% <0.00%> (ø)
pkg/webhook/inject/inject.go 73.49% <0.00%> (-0.68%) ⬇️
pkg/chaosdaemon/util.go 72.48% <9.09%> (-10.60%) ⬇️
pkg/store/experiment/experiment.go 23.14% <9.72%> (-15.63%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0484dba...6c020a4. Read the comment docs.

@cwen0 cwen0 requested review from AngleNet and cwen0 and removed request for AngleNet July 9, 2020 08:47
@YangKeao YangKeao requested a review from fewdan July 9, 2020 12:36
@cwen0 cwen0 requested a review from AngleNet July 10, 2020 02:01
@ti-srebot
Copy link
Contributor

@cwen0,Thanks for your review.

@ti-srebot
Copy link
Contributor

@AngleNet,Thanks for your review.

@cwen0
Copy link
Member

cwen0 commented Jul 13, 2020

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@cwen0
Copy link
Member

cwen0 commented Jul 13, 2020

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 89fe428 into chaos-mesh:master Jul 13, 2020
@YangKeao YangKeao deleted the add_stress_to_pid_namespace branch August 3, 2020 03:43
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
* add -F and corresponding arguments to nsenter

Signed-off-by: yangkeao <[email protected]>

* use infinite reader as stdin

Signed-off-by: Yang Keao <[email protected]>

* normal program

Signed-off-by: Yang Keao <[email protected]>

* don't use toolkit in busybox!

Signed-off-by: Yang Keao <[email protected]>

* remove no-fork for nsenter

Signed-off-by: Yang Keao <[email protected]>

* add new pgid

Signed-off-by: Yang Keao <[email protected]>

* dev on minikube

Signed-off-by: Yang Keao <[email protected]>

* add logs and kill children

Signed-off-by: Yang Keao <[email protected]>

* check back value.yaml

Signed-off-by: Yang Keao <[email protected]>

* remove redundant logs

Signed-off-by: Yang Keao <[email protected]>

Co-authored-by: AngleNet <[email protected]>
Co-authored-by: CWen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants