Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetworkChaos on all address of DNS lookup result #693

Merged
merged 1 commit into from
Jul 14, 2020

Conversation

YangKeao
Copy link
Member

Signed-off-by: Yang Keao [email protected]

What problem does this PR solve?

Fix #692

What is changed and how does it work?

Return all results from dns lookup in ResolveCidr

Check List

Tests

  • Manual test

Code changes

  • Has Go code change

@codecov-commenter
Copy link

Codecov Report

Merging #693 into master will decrease coverage by 1.24%.
The diff coverage is 36.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #693      +/-   ##
==========================================
- Coverage   55.78%   54.53%   -1.25%     
==========================================
  Files          68       69       +1     
  Lines        4383     4652     +269     
==========================================
+ Hits         2445     2537      +92     
- Misses       1768     1926     +158     
- Partials      170      189      +19     
Impacted Files Coverage Δ
api/v1alpha1/networkchaos_types.go 22.98% <ø> (ø)
api/v1alpha1/podchaos_types.go 37.14% <ø> (ø)
controllers/networkchaos/netem/utils.go 0.00% <0.00%> (ø)
pkg/chaosdaemon/netlink_linux.go 0.00% <0.00%> (ø)
pkg/chaosdaemon/stress_server_linux.go 0.00% <0.00%> (ø)
pkg/chaosdaemon/tc_linux.go 42.85% <0.00%> (ø)
pkg/utils/chaosdaemon.go 51.21% <0.00%> (ø)
pkg/utils/grpc.go 0.00% <0.00%> (ø)
pkg/webhook/inject/inject.go 73.49% <0.00%> (-0.68%) ⬇️
pkg/chaosdaemon/util.go 72.48% <9.09%> (-10.60%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1781506...c08c933. Read the comment docs.

@YangKeao YangKeao requested review from cwen0 and fewdan July 14, 2020 03:40
@YangKeao YangKeao added the type/bug-fix Fix for a previously reported bug. label Jul 14, 2020
Copy link
Contributor

@zhouqiang-cl zhouqiang-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member

cwen0 commented Jul 14, 2020

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit a67bcd1 into chaos-mesh:master Jul 14, 2020
@YangKeao YangKeao deleted the fix-692 branch August 3, 2020 03:43
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge status/LGT2 type/bug-fix Fix for a previously reported bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

externalTargets not working as expected with hostnames resolving to multiple ip addresses
5 participants