-
Notifications
You must be signed in to change notification settings - Fork 850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: support filter events by pod name #725
Conversation
Signed-off-by: Yue Yang <[email protected]>
166c800
to
ab0969d
Compare
Codecov Report
@@ Coverage Diff @@
## master #725 +/- ##
==========================================
- Coverage 55.78% 54.31% -1.47%
==========================================
Files 68 69 +1
Lines 4383 4671 +288
==========================================
+ Hits 2445 2537 +92
- Misses 1768 1945 +177
- Partials 170 189 +19
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Umm, I need to revisit the datasource plugin to see if it is useful to support searching by pod name and pod ns.
/merge |
/run-all-tests |
@g1eny0ung merge failed. |
/merge |
/run-all-tests |
Signed-off-by: Yue Yang <[email protected]> Co-authored-by: ti-srebot <[email protected]>
What problem does this PR solve?
As the title. This PR supports filter events by pod name.