Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support filter events by pod name #725

Merged
merged 2 commits into from
Jul 23, 2020

Conversation

g1eny0ung
Copy link
Member

What problem does this PR solve?

As the title. This PR supports filter events by pod name.

@g1eny0ung g1eny0ung requested review from cwen0 and fewdan July 22, 2020 07:54
@g1eny0ung g1eny0ung force-pushed the chore/events-by-pod branch from 166c800 to ab0969d Compare July 22, 2020 07:54
@codecov-commenter
Copy link

Codecov Report

Merging #725 into master will decrease coverage by 1.46%.
The diff coverage is 33.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #725      +/-   ##
==========================================
- Coverage   55.78%   54.31%   -1.47%     
==========================================
  Files          68       69       +1     
  Lines        4383     4671     +288     
==========================================
+ Hits         2445     2537      +92     
- Misses       1768     1945     +177     
- Partials      170      189      +19     
Impacted Files Coverage Δ
api/v1alpha1/common_validation.go 100.00% <ø> (ø)
api/v1alpha1/common_webhook.go 100.00% <ø> (ø)
api/v1alpha1/iochaos_types.go 39.43% <0.00%> (-0.57%) ⬇️
api/v1alpha1/iochaos_webhook.go 93.10% <ø> (ø)
api/v1alpha1/kernelchaos_types.go 19.71% <0.00%> (-0.29%) ⬇️
api/v1alpha1/kernelchaos_webhook.go 85.18% <ø> (ø)
api/v1alpha1/kinds.go 26.66% <ø> (ø)
api/v1alpha1/networkchaos_types.go 22.83% <0.00%> (-0.15%) ⬇️
api/v1alpha1/podchaos_types.go 36.61% <0.00%> (-0.53%) ⬇️
api/v1alpha1/podchaos_webhook.go 81.96% <ø> (ø)
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 438941d...ab0969d. Read the comment docs.

Copy link
Contributor

@zhouqiang-cl zhouqiang-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Umm, I need to revisit the datasource plugin to see if it is useful to support searching by pod name and pod ns.

@cwen0
Copy link
Member

cwen0 commented Jul 23, 2020

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@g1eny0ung merge failed.

@g1eny0ung
Copy link
Member Author

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 3d92efd into chaos-mesh:master Jul 23, 2020
@g1eny0ung g1eny0ung deleted the chore/events-by-pod branch July 24, 2020 02:56
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants