-
Notifications
You must be signed in to change notification settings - Fork 850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[update] update website/doc , remove '$' in shell #747
Conversation
Signed-off-by: “fewdan” <[email protected]>
Signed-off-by: “fewdan” <[email protected]>
Signed-off-by: “fewdan” <[email protected]>
Signed-off-by: “fewdan” <[email protected]>
Signed-off-by: “fewdan” <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The website changes look good.
pkg/apiserver/event/event.go
Outdated
@@ -71,6 +71,7 @@ func Register(r *gin.RouterGroup, s *Service) { | |||
// @Param experimentNamespace query string false "The namespace of the experiment" | |||
// @Param uid query string false "The UID of the experiment" | |||
// @Param kind query string false "kind" Enums(PodChaos, IoChaos, NetworkChaos, TimeChaos, KernelChaos, StressChaos) | |||
// @Param limit query string false "The max length of events list" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these limit changes related?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
* update Signed-off-by: “fewdan” <[email protected]> * update Signed-off-by: “fewdan” <[email protected]> * update Signed-off-by: “fewdan” <[email protected]> * remove $ in shell Signed-off-by: “fewdan” <[email protected]> * update Signed-off-by: “fewdan” <[email protected]> Co-authored-by: CWen <[email protected]>
What problem does this PR solve?
update website/doc , remove '$' in shell