Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[update] update website/doc , remove '$' in shell #747

Merged
merged 7 commits into from
Jul 29, 2020
Merged

[update] update website/doc , remove '$' in shell #747

merged 7 commits into from
Jul 29, 2020

Conversation

fewdan
Copy link
Member

@fewdan fewdan commented Jul 28, 2020

What problem does this PR solve?

update website/doc , remove '$' in shell

fewdan added 6 commits July 27, 2020 15:55
Signed-off-by: “fewdan” <[email protected]>
Signed-off-by: “fewdan” <[email protected]>
Signed-off-by: “fewdan” <[email protected]>
Signed-off-by: “fewdan” <[email protected]>
Signed-off-by: “fewdan” <[email protected]>
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The website changes look good.

@@ -71,6 +71,7 @@ func Register(r *gin.RouterGroup, s *Service) {
// @Param experimentNamespace query string false "The namespace of the experiment"
// @Param uid query string false "The UID of the experiment"
// @Param kind query string false "kind" Enums(PodChaos, IoChaos, NetworkChaos, TimeChaos, KernelChaos, StressChaos)
// @Param limit query string false "The max length of events list"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these limit changes related?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yeya24 please see #742 .
I made a mistake when switching branches.

Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member

cwen0 commented Jul 29, 2020

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 6923b8c into chaos-mesh:master Jul 29, 2020
@fewdan fewdan deleted the doc branch July 29, 2020 08:36
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
* update

Signed-off-by: “fewdan” <[email protected]>

* update

Signed-off-by: “fewdan” <[email protected]>

* update

Signed-off-by: “fewdan” <[email protected]>

* remove $ in shell

Signed-off-by: “fewdan” <[email protected]>

* update

Signed-off-by: “fewdan” <[email protected]>

Co-authored-by: CWen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants