Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in network chaos and enrich e2e case #778

Merged
merged 3 commits into from
Aug 3, 2020

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Aug 3, 2020

What problem does this PR solve?

  1. Network partition failed when mode set to all #771 all iptables commands share the same lock /run/xtables.lock on chaos-daemon, so it have to wait (-w)

  2. Fix bug about both direction.

  3. Enrich the e2e case of network chaos

Check List

Tests

  • E2E test

Code changes

  • Has Go code change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to update the documentation

`/run/xtables.lock` is on chaos-daemon

Signed-off-by: Yang Keao <[email protected]>
@YangKeao YangKeao requested a review from cwen0 August 3, 2020 06:02
@zhouqiang-cl
Copy link
Contributor

/run-e2e-tests

Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zhouqiang-cl zhouqiang-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouqiang-cl
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 777

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 7d41d45 into chaos-mesh:master Aug 3, 2020
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
* fix  bugs and add tests in network chaos

Signed-off-by: Yang Keao <[email protected]>

* all iptables operation share the same lock

`/run/xtables.lock` is on chaos-daemon

Signed-off-by: Yang Keao <[email protected]>

Co-authored-by: ti-srebot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants