fix build information when to build in docker #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cwen0 <[email protected]>
Signed-off-by: cwen0 <[email protected]>
YangKeao
reviewed
Aug 4, 2020
|
|
||
| COPY . /src | ||
| WORKDIR /src | ||
| RUN --mount=type=cache,target=/root/.cache/go-build \ | ||
| make binary | ||
| IMG_LDFLAGS=$LDFLAGS make binary |
There was a problem hiding this comment.
Why not name "IMG_LDFLAGS" as "LDFLAGS" directly?
There was a problem hiding this comment.
We need to reference IMG_LDFLAGS to LDFLAGS in Makefile, If we use LDFLAGS directly, an error will be report when compiling:
Recursive variable `LDFLAGS' references itself (eventually). Stop.
ti-srebot
approved these changes
Aug 4, 2020
|
/merge |
|
/run-all-tests |
sjwsl
pushed a commit
to sjwsl/chaos-mesh
that referenced
this pull request
May 6, 2021
* fix build information when to build in docker Signed-off-by: cwen0 <[email protected]> * make good Signed-off-by: cwen0 <[email protected]> Co-authored-by: ti-srebot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: cwen0 [email protected]
What problem does this PR solve?
Fix:
Fixed:
Controller manager Version: version.Info{GitVersion:"v1.0.0-alpha.1.156+4463f1d8c63391", GitCommit:"4463f1d8c633918962b96a73553ae848677558b8", BuildDate:"2020-08-04T07:37:13Z", GoVersion:"go1.14.4", Compiler:"gc", Platform:"linux/amd64"}What is changed and how does it work?
Add a build-arg