Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upload install scripts and crd files workflows #806

Merged
merged 3 commits into from
Aug 12, 2020

Conversation

cwen0
Copy link
Member

@cwen0 cwen0 commented Aug 12, 2020

Signed-off-by: cwen0 [email protected]

What problem does this PR solve?

When pushing a tag, we need to upload the install scripts and CRD files regardless of whether the files were changed.

  • Use AWS CLI directly
  • Add a single file to release files when pushing a tag

cwen0 added 2 commits August 12, 2020 14:22
Signed-off-by: cwen0 <[email protected]>
Signed-off-by: cwen0 <[email protected]>
@cwen0 cwen0 removed the status/WIP label Aug 12, 2020
Copy link
Member

@fewdan fewdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fewdan
Copy link
Member

fewdan commented Aug 12, 2020

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@cwen0 merge failed.

@fewdan
Copy link
Member

fewdan commented Aug 12, 2020

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 09d3dfb into chaos-mesh:master Aug 12, 2020
@cwen0 cwen0 deleted the fix_github_workflow branch August 19, 2020 06:20
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
* remove_paths

Signed-off-by: cwen0 <[email protected]>

* upload more files

Signed-off-by: cwen0 <[email protected]>

* use awscli instead of cloud-assets-utils

Signed-off-by: cwen0 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants