refactor: entrance of chaos dashboard #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g1eny0ung
force-pushed
the
refactor/chaos-dashboard-main
branch
from
a3fbdb0 to
9d5124c
Compare
Signed-off-by: Yue Yang <[email protected]>
g1eny0ung
force-pushed
the
refactor/chaos-dashboard-main
branch
from
9d5124c to
3ce0019
Compare
Signed-off-by: Yue Yang <[email protected]>
Signed-off-by: Yue Yang <[email protected]>
Signed-off-by: Yue Yang <[email protected]>
Signed-off-by: Yue Yang <[email protected]>
Signed-off-by: Yue Yang <[email protected]>
Signed-off-by: Yue Yang <[email protected]>
Signed-off-by: Yue Yang <[email protected]>
Signed-off-by: Yue Yang <[email protected]>
Signed-off-by: Yue Yang <[email protected]>
|
I run this pr in my environment, but when I refresh the dashboard, the link will be directed to the |
Signed-off-by: Yue Yang <[email protected]>
Signed-off-by: Yue Yang <[email protected]>
Signed-off-by: Yue Yang <[email protected]>
ti-srebot
approved these changes
Sep 10, 2020
|
/merge |
|
/run-all-tests |
|
/run-all-tests |
|
/merge |
|
/run-all-tests |
STRRL
pushed a commit
to STRRL/chaos-mesh
that referenced
this pull request
Sep 10, 2020
Signed-off-by: STRRL <[email protected]>
6 tasks
|
cherry pick to release-1.0 in PR #895 |
cwen0
pushed a commit
that referenced
this pull request
Sep 11, 2020
* refactor: entrance of chaos dashboard Signed-off-by: Yue Yang <[email protected]> * fix: go.mod Signed-off-by: Yue Yang <[email protected]> * chore: update Signed-off-by: Yue Yang <[email protected]> * refactor: use gin-swagger and rewrite uiserver Signed-off-by: Yue Yang <[email protected]> * chore: update Signed-off-by: Yue Yang <[email protected]> * fix: typo Signed-off-by: Yue Yang <[email protected]> * chore: update Signed-off-by: Yue Yang <[email protected]> * fix: ci Signed-off-by: Yue Yang <[email protected]> * fix: ci Signed-off-by: Yue Yang <[email protected]> * fix: ci Signed-off-by: Yue Yang <[email protected]> * fix: server rendering Signed-off-by: Yue Yang <[email protected]> * fix: remove useless Signed-off-by: Yue Yang <[email protected]> * fix: remove duplicates Signed-off-by: Yue Yang <[email protected]> Co-authored-by: Yue Yang <[email protected]>
sjwsl
pushed a commit
to sjwsl/chaos-mesh
that referenced
this pull request
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yue Yang [email protected]
What problem does this PR solve?
This PR optimizes the dashboard entry file, the main changes are:
pkg/config/pingroute because we have many routes to check the server whether running or notswaggerserverby usinggin-swaggeruiserverWhat is changed and how does it work?
Due to the UI folder can't be served in the root route. (Because /* routes will conflict to other routes).
I change the UI route basename to
/dashboardand the/root will redirect todashboardpermanently, all changes are backward compatible.Checklist
Tests
Side effects
Related changes
Does this PR introduce a user-facing change?