Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: doc versions #883

Merged
merged 2 commits into from
Sep 8, 2020
Merged

Conversation

g1eny0ung
Copy link
Member

Signed-off-by: Yue Yang [email protected]

What problem does this PR solve?

As the title.

What is changed and how does it work?

Checklist

Tests

  • Unit test
  • E2E test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Breaking backward compatibility

Related changes

  • Need to update the documentation

Does this PR introduce a user-facing change?

NONE

Signed-off-by: Yue Yang <[email protected]>
@g1eny0ung g1eny0ung requested review from fewdan and cwen0 September 8, 2020 11:43
Copy link
Contributor

@zhouqiang-cl zhouqiang-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fewdan
Copy link
Member

fewdan commented Sep 8, 2020

/merge

@cwen0
Copy link
Member

cwen0 commented Sep 8, 2020

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit f128602 into chaos-mesh:master Sep 8, 2020
@g1eny0ung g1eny0ung deleted the fix/doc-versions branch September 9, 2020 07:22
STRRL pushed a commit to STRRL/chaos-mesh that referenced this pull request Sep 10, 2020
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants