[update] add client.Reader in Reconciler #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: “fewdan” <[email protected]>
Signed-off-by: “fewdan” <[email protected]>
Signed-off-by: “fewdan” <[email protected]>
Signed-off-by: “fewdan” <[email protected]>
Signed-off-by: “fewdan” <[email protected]>
Signed-off-by: “fewdan” <[email protected]>
yeya24
previously approved these changes
Sep 9, 2020
Signed-off-by: “fewdan” <[email protected]>
|
@yeya24 I have dealt with the other comments, but the e2e test seems inconvenient to add. I tested it manually before. |
ti-srebot
previously approved these changes
Sep 10, 2020
|
Passing an argument to every function is really annoying (:crying_cat_face: I need |
|
/merge |
|
/run-all-tests |
|
@fewdan merge failed. |
Signed-off-by: “fewdan” <[email protected]>
Signed-off-by: “fewdan” <[email protected]>
Signed-off-by: “fewdan” <[email protected]>
Signed-off-by: “fewdan” <[email protected]>
|
/merge |
|
/run-all-tests |
ti-srebot
approved these changes
Sep 10, 2020
|
/merge |
|
/run-all-tests |
STRRL
pushed a commit
to STRRL/chaos-mesh
that referenced
this pull request
Sep 10, 2020
* update Signed-off-by: “fewdan” <[email protected]> * update Signed-off-by: “fewdan” <[email protected]> * update Signed-off-by: “fewdan” <[email protected]> * fix vet Signed-off-by: “fewdan” <[email protected]> * fix go vet Signed-off-by: “fewdan” <[email protected]> * update Signed-off-by: “fewdan” <[email protected]> * address comments Signed-off-by: “fewdan” <[email protected]> * update Signed-off-by: “fewdan” <[email protected]> * update Signed-off-by: “fewdan” <[email protected]> * update Signed-off-by: “fewdan” <[email protected]> * address comment Signed-off-by: “fewdan” <[email protected]>
|
cherry pick to release-1.0 failed |
4 tasks
sjwsl
pushed a commit
to sjwsl/chaos-mesh
that referenced
this pull request
May 6, 2021
* update Signed-off-by: “fewdan” <[email protected]> * update Signed-off-by: “fewdan” <[email protected]> * update Signed-off-by: “fewdan” <[email protected]> * fix vet Signed-off-by: “fewdan” <[email protected]> * fix go vet Signed-off-by: “fewdan” <[email protected]> * update Signed-off-by: “fewdan” <[email protected]> * address comments Signed-off-by: “fewdan” <[email protected]> * update Signed-off-by: “fewdan” <[email protected]> * update Signed-off-by: “fewdan” <[email protected]> * update Signed-off-by: “fewdan” <[email protected]> * address comment Signed-off-by: “fewdan” <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: “fewdan” [email protected]
What problem does this PR solve?
solve #878
What is changed and how does it work?
add client.Reader in Reconciler
Checklist
Tests
Side effects
Related changes
Does this PR introduce a user-facing change?