[update] add DeleteIncompleteExperiments #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: “fewdan” <[email protected]>
fewdan
added
needs-cherry-pick-1.0
type/bug-fix
g1eny0ung
previously approved these changes
Sep 21, 2020
Signed-off-by: “fewdan” <[email protected]>
ti-srebot
previously approved these changes
Sep 21, 2020
Signed-off-by: “fewdan” <[email protected]>
|
@WangXiangUSTC,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIG: chaos-mesh(slack). |
|
/merge |
|
/run-all-tests |
6 tasks
|
cherry pick to release-1.0 in PR #933 |
cwen0
pushed a commit
that referenced
this pull request
Sep 21, 2020
* add DeleteIncompleteExperiments Signed-off-by: “fewdan” <[email protected]> * address comment Signed-off-by: “fewdan” <[email protected]> * address comment Signed-off-by: “fewdan” <[email protected]> Co-authored-by: “fewdan” <[email protected]>
sjwsl
pushed a commit
to sjwsl/chaos-mesh
that referenced
this pull request
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: “fewdan” [email protected]
What problem does this PR solve?
#923
What is changed and how does it work?
If the chaos-dashboard was restarted and the experiment is completed during the restart, which means the experiment would never save the finish_time.
DeleteIncompleteExperiments can be used to delete all incomplete experiments to avoid this case.
Checklist
Tests
Side effects
Related changes
Does this PR introduce a user-facing change?