Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validation problem in dashboard #968

Merged
merged 1 commit into from
Sep 25, 2020

Conversation

g1eny0ung
Copy link
Member

Signed-off-by: Yue Yang [email protected]

What problem does this PR solve?

This PR fixes the labels' validation problem temporarily and should be recheck after version 1.0

Also, resolve a tiny bug about displaying the experiment state.

What is changed and how does it work?

Checklist

Tests

  • Unit test
  • E2E test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Breaking backward compatibility

Related changes

  • Need to update the documentation

Does this PR introduce a user-facing change?

NONE

Signed-off-by: Yue Yang <[email protected]>
Copy link
Member

@fewdan fewdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member

cwen0 commented Sep 25, 2020

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 83a2175 into chaos-mesh:master Sep 25, 2020
@ti-srebot
Copy link
Contributor

cherry pick to release-1.0 in PR #970

@g1eny0ung g1eny0ung deleted the fix/dashboard branch September 25, 2020 12:19
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants