Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag to control the version of Chaos Mesh in install.sh #969

Merged
merged 2 commits into from
Sep 25, 2020

Conversation

cwen0
Copy link
Member

@cwen0 cwen0 commented Sep 25, 2020

Signed-off-by: cwen0 [email protected]

What problem does this PR solve?

Add a flag -v to control the version of Chaos Mesh in install.sh.

What is changed and how does it work?

install.sh -v v0.9.1

Checklist

Tests

  • Unit test
  • E2E test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Breaking backward compatibility

Related changes

  • Need to update the documentation

Does this PR introduce a user-facing change?

NONE

fewdan
fewdan previously approved these changes Sep 25, 2020
WangXiangUSTC
WangXiangUSTC previously approved these changes Sep 25, 2020
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ti-srebot
ti-srebot previously approved these changes Sep 25, 2020
Signed-off-by: cwen0 <[email protected]>
@cwen0 cwen0 dismissed stale reviews from ti-srebot, WangXiangUSTC, and fewdan via e04df79 September 25, 2020 08:04
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YangKeao
Copy link
Member

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

cherry pick to release-1.0 in PR #973

@cwen0 cwen0 deleted the fix_install_script_version branch September 25, 2020 08:16
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants