Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[update] fix multiple events have been recoreded #972

Merged
merged 12 commits into from
Sep 25, 2020
Merged

[update] fix multiple events have been recoreded #972

merged 12 commits into from
Sep 25, 2020

Conversation

fewdan
Copy link
Member

@fewdan fewdan commented Sep 25, 2020

What problem does this PR solve?

#959

What is changed and how does it work?

Before creating an event, check whether the event exists.

Checklist

Tests

  • Unit test
  • E2E test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Breaking backward compatibility

Related changes

  • Need to update the documentation

Does this PR introduce a user-facing change?

NONE

fewdan and others added 10 commits September 17, 2020 19:27
@fewdan fewdan added status/PTAL type/bug-fix Fix for a previously reported bug. labels Sep 25, 2020
Signed-off-by: “fewdan” <[email protected]>
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member

cwen0 commented Sep 25, 2020

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 427017f into chaos-mesh:master Sep 25, 2020
@ti-srebot
Copy link
Contributor

cherry pick to release-1.0 failed

@fewdan fewdan deleted the iss959 branch September 25, 2020 09:18
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge status/LGT2 type/bug-fix Fix for a previously reported bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants