Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

last_plan_from_binding documented but not merged #3998

Closed
ghost opened this issue Sep 30, 2020 · 4 comments · Fixed by #4300
Closed

last_plan_from_binding documented but not merged #3998

ghost opened this issue Sep 30, 2020 · 4 comments · Fixed by #4300

Comments

@ghost
Copy link

ghost commented Sep 30, 2020

Error Report

This repository is ONLY used to solve issues related to DOCS.
For other issues (related to TiDB, PD, etc), please move to other repositories.

Please answer the following questions before submitting your issue. Thanks!

  1. What is the URL/path of the document related to this issue?

See: https://docs.pingcap.com/tidb/stable/system-variables#last_plan_from_binding-new-in-v40

  1. How would you like to improve it?

This references a feature which has not merged yet: pingcap/tidb#18017 -- if it doesn't merge, it should be removed from the docs to reduce confusion (it confused me!)

@ghost ghost mentioned this issue Oct 13, 2020
9 tasks
@github-actions
Copy link

This issue is stale because it has been open for 60 days with no activity. If no comment has been made and the lifecycle/stale label is not removed, this issue will be closed in 15 days.

@github-actions github-actions bot added the lifecycle/stale This issue has been open for 60 days with no activity. label Nov 30, 2020
@TomShawn
Copy link
Contributor

@nullnotnil Can this issue be closed now?

@ghost
Copy link
Author

ghost commented Nov 30, 2020

Yes

@ghost ghost closed this as completed Nov 30, 2020
@ghost ghost reopened this Nov 30, 2020
@ghost
Copy link
Author

ghost commented Nov 30, 2020

Actually, I double checked the PR. It is in master branch only. I think because of the high rate of conflicts, it won't immediately be cherry picked. We should remove the docs about this for the stable docs.

@ghost ghost removed the lifecycle/stale This issue has been open for 60 days with no activity. label Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant