-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schedule: operator limit for stores #1474
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1474 +/- ##
==========================================
- Coverage 68.07% 67.51% -0.56%
==========================================
Files 159 159
Lines 15843 16134 +291
==========================================
+ Hits 10785 10893 +108
- Misses 4100 4269 +169
- Partials 958 972 +14
Continue to review full report at Codecov.
|
a7df917
to
a1a1921
Compare
2a41999
to
2df2083
Compare
e93bf61
to
aa79ff9
Compare
7643be0
to
5713c77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
/rebuild |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and can be merged for its correctness, however, the design is recommended to be discussed and improved later.
Signed-off-by: nolouch <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
/rebuild |
* tiny clean up code (#1526) Signed-off-by: Ryan Leung <[email protected]> * config: enable use region storage by default (#1524) * config: default enable use region storage * schedulers: let hot region balance not affect by balance-region-scheduler-limit (#1522) Signed-off-by: nolouch <[email protected]> * log: do not add stack to error log (#1532) * *: replace gofail with pingcap/failpoint (#1534) * *: replace gofail with pingcap/failpoint Signed-off-by: disksing <[email protected]> * fix typo Signed-off-by: disksing <[email protected]> * fix typo Signed-off-by: disksing <[email protected]> * Update server/cluster_test.go Co-Authored-By: Lonng <[email protected]> * Update server/tso.go Co-Authored-By: Lonng <[email protected]> * Update server/tso.go Co-Authored-By: Lonng <[email protected]> * check enable failpoint result Signed-off-by: disksing <[email protected]> * Update server/cluster.go Co-Authored-By: Lonng <[email protected]> * server: set timeout for MoveLeader (#1533) * server: set timeout for MoveLeader Signed-off-by: disksing <[email protected]> * client, server: add ScanRegions gRPC protocol support (#1535) * client, server: support ScanRegions gRPC protocol Signed-off-by: disksing <[email protected]> * schedule: actively push operator (#1536) * schedule: actively push operator Signed-off-by: nolouch <[email protected]> * *: update some dead links (#1543) * update links Signed-off-by: Ryan Leung <[email protected]> * Add windows build script (#1540) Signed-off-by: Ana Hobden <[email protected]> * fix operator timeout metrics (#1541) Signed-off-by: Ryan Leung <[email protected]> * *:Rollback config in store when kv.persist failed (#1476) * tests: independent region sync test (#1545) * tests: independent syncer region test Signed-off-by: nolouch <[email protected]> * schedule: operator limit for stores (#1474) * add store limit for scheduling Signed-off-by: Ryan Leung <[email protected]> * statistic: add the statistic of flow (#1548) * store_statistic: add the statistic of flow Signed-off-by: nolouch <[email protected]>
What problem does this PR solve?
We can not control the operators' cost in a store.
What is changed and how it works?
This PR adds an overloaded filter for stores. If the operators' cost in a store exceeds
StoreMaxScheduleCost
, the store will be filtered.Also if the total cost of current running operators exceeds
MaxScheduleCost
, the newly created operator will be not added into running operators.Check List
Tests