client, server: add ScanRegions gRPC protocol support #1535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: disksing <[email protected]>
Signed-off-by: disksing <[email protected]>
Signed-off-by: disksing <[email protected]>
Signed-off-by: disksing <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1535 +/- ##
==========================================
+ Coverage 67.46% 67.69% +0.22%
==========================================
Files 158 158
Lines 15659 15689 +30
==========================================
+ Hits 10565 10620 +55
+ Misses 4130 4102 -28
- Partials 964 967 +3
Continue to review full report at Codecov.
|
Signed-off-by: disksing <[email protected]>
MyonKeminta
reviewed
May 16, 2019
|
Rest LGTM |
nolouch
approved these changes
May 16, 2019
Signed-off-by: disksing <[email protected]>
MyonKeminta
reviewed
May 16, 2019
Signed-off-by: disksing <[email protected]>
Signed-off-by: disksing <[email protected]>
|
/test |
|
/rebuild |
nolouch
added a commit
that referenced
this pull request
May 23, 2019
* tiny clean up code (#1526) Signed-off-by: Ryan Leung <[email protected]> * config: enable use region storage by default (#1524) * config: default enable use region storage * schedulers: let hot region balance not affect by balance-region-scheduler-limit (#1522) Signed-off-by: nolouch <[email protected]> * log: do not add stack to error log (#1532) * *: replace gofail with pingcap/failpoint (#1534) * *: replace gofail with pingcap/failpoint Signed-off-by: disksing <[email protected]> * fix typo Signed-off-by: disksing <[email protected]> * fix typo Signed-off-by: disksing <[email protected]> * Update server/cluster_test.go Co-Authored-By: Lonng <[email protected]> * Update server/tso.go Co-Authored-By: Lonng <[email protected]> * Update server/tso.go Co-Authored-By: Lonng <[email protected]> * check enable failpoint result Signed-off-by: disksing <[email protected]> * Update server/cluster.go Co-Authored-By: Lonng <[email protected]> * server: set timeout for MoveLeader (#1533) * server: set timeout for MoveLeader Signed-off-by: disksing <[email protected]> * client, server: add ScanRegions gRPC protocol support (#1535) * client, server: support ScanRegions gRPC protocol Signed-off-by: disksing <[email protected]> * schedule: actively push operator (#1536) * schedule: actively push operator Signed-off-by: nolouch <[email protected]> * *: update some dead links (#1543) * update links Signed-off-by: Ryan Leung <[email protected]> * Add windows build script (#1540) Signed-off-by: Ana Hobden <[email protected]> * fix operator timeout metrics (#1541) Signed-off-by: Ryan Leung <[email protected]> * *:Rollback config in store when kv.persist failed (#1476) * tests: independent region sync test (#1545) * tests: independent syncer region test Signed-off-by: nolouch <[email protected]> * schedule: operator limit for stores (#1474) * add store limit for scheduling Signed-off-by: Ryan Leung <[email protected]> * statistic: add the statistic of flow (#1548) * store_statistic: add the statistic of flow Signed-off-by: nolouch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
There are use cases need to iterate all PD regions (for example TiDB resolveLock). It is too slow to query regions one by one.
What is changed and how it works?
Add
ScanRegionsgRPC method to query regions in batch.Note: Merge after pingcap/kvproto#396
Check List
Tests
Side effects
Related changes