Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedule: adjust store balance rate meaning #1591

Merged
merged 1 commit into from
Jun 20, 2019

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jun 20, 2019

What problem does this PR solve?

cherry-pick #1589.

Check List

Tests

  • Unit test

Code changes

  • Has configuration change

@codecov-io
Copy link

Codecov Report

Merging #1591 into release-3.0 will decrease coverage by 0.19%.
The diff coverage is 33.33%.

Impacted file tree graph

@@              Coverage Diff               @@
##           release-3.0    #1591     +/-   ##
==============================================
- Coverage        67.83%   67.63%   -0.2%     
==============================================
  Files              159      159             
  Lines            16258    16258             
==============================================
- Hits             11028    10996     -32     
- Misses            4273     4292     +19     
- Partials           957      970     +13
Impacted Files Coverage Δ
server/schedule/mockcluster.go 82.25% <ø> (ø) ⬆️
server/config.go 82.33% <ø> (ø) ⬆️
server/api/store.go 51.87% <0%> (ø) ⬆️
server/schedule/operator_controller.go 86.38% <100%> (ø) ⬆️
pkg/testutil/operator_check.go 72.22% <0%> (-11.12%) ⬇️
pkg/etcdutil/etcdutil.go 86.04% <0%> (-9.31%) ⬇️
server/region_syncer/client.go 79.74% <0%> (-3.8%) ⬇️
server/leader.go 79.59% <0%> (-3.68%) ⬇️
server/util.go 75.49% <0%> (-2.65%) ⬇️
server/grpc_service.go 58.36% <0%> (-2.37%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57238dd...64ac4a4. Read the comment docs.

Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rleungx rleungx merged commit daee3d1 into tikv:release-3.0 Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants