-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics: introduce TopN #1998
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1998 +/- ##
==========================================
+ Coverage 77.56% 77.74% +0.18%
==========================================
Files 178 179 +1
Lines 18240 18407 +167
==========================================
+ Hits 14147 14310 +163
- Misses 3013 3015 +2
- Partials 1080 1082 +2
Continue to review full report at Codecov.
|
disksing
reviewed
Dec 9, 2019
the rest LGTM. |
disksing
approved these changes
Dec 9, 2019
nolouch
approved these changes
Dec 10, 2019
nolouch
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Dec 10, 2019
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/schedule
Scheduling logic.
status/can-merge
Indicates a PR has been approved by a committer.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
First step of issue #1997 .
What is changed and how it works?
Add
TopN
, a container maintaining top-N items with TTL-based GC.Check List
Tests