-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: prevent store limit from changing to zero (#2586) #2588
Conversation
Signed-off-by: Ryan Leung <[email protected]>
Codecov Report
@@ Coverage Diff @@
## release-4.0 #2588 +/- ##
===============================================
+ Coverage 77.13% 77.21% +0.07%
===============================================
Files 205 205
Lines 22129 22129
===============================================
+ Hits 17070 17086 +16
+ Misses 3756 3742 -14
+ Partials 1303 1301 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
Sorry @nolouch, you don't have permission to trigger auto merge event on this branch. |
/merge |
Sorry @disksing, you don't have permission to trigger auto merge event on this branch. |
/merge |
Your auto merge job has been accepted, waiting for:
|
/run-all-tests |
cherry-pick #2586 to release-4.0
What problem does this PR solve?
Closes #2584.
What is changed and how it works?
When setting the store limit, we first check if it is zero and reject the request if it is.
Check List
Tests
Related changes
Release note