Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: fix the deploy path not being updated (#2596) #2600

Merged
merged 2 commits into from
Jul 2, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #2596 to release-4.0


What problem does this PR solve?

Closes #2595.

What is changed and how it works?

This PR updates the existed store's deploy path when Putstore is called after restarting.

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Fix the issue that the deploy path of the store is not updated if the deploy directory is moved

@codecov-commenter
Copy link

Codecov Report

Merging #2600 into release-4.0 will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-4.0    #2600      +/-   ##
===============================================
+ Coverage        77.13%   77.25%   +0.11%     
===============================================
  Files              205      205              
  Lines            22129    22135       +6     
===============================================
+ Hits             17070    17101      +31     
+ Misses            3756     3739      -17     
+ Partials          1303     1295       -8     
Impacted Files Coverage Δ
server/cluster/cluster.go 81.10% <100.00%> (+0.44%) ⬆️
server/core/store_option.go 100.00% <100.00%> (ø)
server/kv/etcd_kv.go 75.32% <0.00%> (-12.99%) ⬇️
pkg/dashboard/adapter/manager.go 86.79% <0.00%> (-6.61%) ⬇️
server/cluster/coordinator.go 74.52% <0.00%> (-2.20%) ⬇️
server/server.go 76.94% <0.00%> (+0.15%) ⬆️
client/client.go 71.10% <0.00%> (+0.50%) ⬆️
pkg/btree/btree.go 87.65% <0.00%> (+0.80%) ⬆️
server/grpc_service.go 60.03% <0.00%> (+0.96%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bd6bbd...fbc98d1. Read the comment docs.

Copy link
Member

@HunDunDM HunDunDM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@disksing disksing added the status/can-merge Indicates a PR has been approved by a committer. label Jul 2, 2020
@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 2588
  • 2574

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@HunDunDM HunDunDM modified the milestones: v4.0.2, v4.0.3 Jul 2, 2020
@ti-srebot ti-srebot merged commit db0aa7e into tikv:release-4.0 Jul 2, 2020
@disksing disksing deleted the release-4.0-6aca59ab6b0c branch July 2, 2020 09:47
@lhy1024 lhy1024 added the type/bugfix This PR fixes a bug. label Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/misc Some other things. status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants