Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memorize open / close status in statements and slow queries #747

Closed
breezewish opened this issue Aug 26, 2020 · 3 comments · Fixed by #775
Closed

Memorize open / close status in statements and slow queries #747

breezewish opened this issue Aug 26, 2020 · 3 comments · Fixed by #775

Comments

@breezewish
Copy link
Member

Feature Request

Is your feature request related to a problem? Please describe:

Fields are closed by default, like Full SQLs, Execution Plans.

Describe the feature you'd like:

Maybe better to memorize these open / close status.

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

@baurine
Copy link
Collaborator

baurine commented Aug 27, 2020

I don't understand it, according to the code, now we have remembered which columns show, and whether should show full SQL for statement and slow query. We persist them in the local storage.

  const [visibleColumnKeys, setVisibleColumnKeys] = useLocalStorageState(
    VISIBLE_COLUMN_KEYS,
    defColumnKeys
  )
  const [showFullSQL, setShowFullSQL] = useLocalStorageState(
    SHOW_FULL_SQL,
    false
  )

@breezewish
Copy link
Member Author

@baurine I mean these ones

image

@baurine
Copy link
Collaborator

baurine commented Sep 1, 2020

Got it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants