From 953273f9f50d31c6e2d61f903c8017ff5dd8a051 Mon Sep 17 00:00:00 2001 From: Yiding Cui Date: Tue, 29 Nov 2022 00:38:48 +0800 Subject: [PATCH] address comments --- planner/core/partition_pruner_test.go | 3 --- planner/core/task.go | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/planner/core/partition_pruner_test.go b/planner/core/partition_pruner_test.go index 791c0e28bdb3f..166f251b53fc3 100644 --- a/planner/core/partition_pruner_test.go +++ b/planner/core/partition_pruner_test.go @@ -310,9 +310,6 @@ func TestListPartitionPruner(t *testing.T) { partitionPrunerData.LoadTestCases(t, &input, &output) valid := false for i, tt := range input { - if tt == "select * from t1 where (id = 1 and a = 1) or a is null" { - fmt.Println("1") - } testdata.OnRecord(func() { output[i].SQL = tt output[i].Result = testdata.ConvertRowsToStrings(tk.MustQuery(tt).Sort().Rows()) diff --git a/planner/core/task.go b/planner/core/task.go index 9bb62aae718e8..ac3d10a323a7b 100644 --- a/planner/core/task.go +++ b/planner/core/task.go @@ -1050,7 +1050,7 @@ func (p *PhysicalTopN) pushTopNDownToDynamicPartition(copTsk *copTask) (task, bo return nil, false } finalTblScanPlan := copTsk.tablePlan - if len(finalTblScanPlan.Children()) > 0 { + for len(finalTblScanPlan.Children()) > 0 { finalTblScanPlan = finalTblScanPlan.Children()[0] } tblScan = finalTblScanPlan.(*PhysicalTableScan)