Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: pingcap/tidb
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 59e3d2fe5a89bcd2f3fd33e4333d610b16f26f4a
Choose a base ref
..
head repository: pingcap/tidb
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: a3479df4c7629f2544cc418977d400c5ab304681
Choose a head ref
Showing with 2 additions and 1 deletion.
  1. +2 −1 pkg/planner/util/null_misc.go
3 changes: 2 additions & 1 deletion pkg/planner/util/null_misc.go
Original file line number Diff line number Diff line change
@@ -40,7 +40,8 @@ func allConstants(ctx expression.BuildContext, expr expression.Expression) bool
return false
}

// isNullRejectedInList checks null filter for IN list using OR logic. Reason is that null filtering through evaluation by isNullRejectedSimpleExpr
// isNullRejectedInList checks null filter for IN list using OR logic.
// Reason is that null filtering through evaluation by isNullRejectedSimpleExpr
// has problems with IN list.
func isNullRejectedInList(ctx base.PlanContext, expr *expression.ScalarFunction, innerSchema *expression.Schema) bool {
for i, arg := range expr.GetArgs() {