Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize the directory structure of executor package #27762

Open
XuHuaiyu opened this issue Sep 2, 2021 · 3 comments
Open

optimize the directory structure of executor package #27762

XuHuaiyu opened this issue Sep 2, 2021 · 3 comments
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented Sep 2, 2021

Enhancement

There are too many .go files in the package executor, we need to split the files into multiple subdirectories.
executor_package

@XuHuaiyu XuHuaiyu added the type/enhancement The issue or PR belongs to an enhancement. label Sep 2, 2021
@tisonkun
Copy link
Contributor

tisonkun commented Sep 2, 2021

I propose to address this issue along with #26854 since almost functions relate with integration_test.go. Decoupling logics also requests rearrange tests, migration can be done on the fly. Be sure that we refactor code instead of making non-trivial changes.

@hawkingrei
Copy link
Member

Although migrating test-infra to testify have completed, We find we can run test cases more faster and stable in the Bazel if the executor split the files into multiple subdirectories. I hope this enhancement can continue to do.

@Zheaoli
Copy link
Contributor

Zheaoli commented Jun 10, 2022

Maybe I can make a try to split the directory(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

No branches or pull requests

4 participants