Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support query attributed in client protocol since 8.0.23 #55174

Open
Tracked by #7968
kafka1991 opened this issue Aug 4, 2024 · 2 comments · May be fixed by #55175
Open
Tracked by #7968

Support query attributed in client protocol since 8.0.23 #55174

kafka1991 opened this issue Aug 4, 2024 · 2 comments · May be fixed by #55175
Assignees
Labels
compatibility-mysql80 This is a compatibility issue with MySQL 8.0(but NOT 5.7) compatibility-mysql84 This is a compatibility issue with MySQL 8.4 component/mysql-protocol sig/sql-infra SIG: SQL Infra type/compatibility type/feature-request Categorizes issue or PR as related to a new feature.

Comments

@kafka1991
Copy link
Contributor

kafka1991 commented Aug 4, 2024

Feature Request

Is your feature request related to a problem? Please describe:

Improve compatibility with mysql 8.0 query attribute feature, both for protocol and build-in function.
Query Attributes document
Details of protocol: https://archive.fosdem.org/2021/schedule/event/mysql_protocl/attachments/slides/4274/export/events/attachments/mysql_protocl/slides/4274/FOSDEM21_MySQL_Protocols_Query_Attributes.pdf

Describe the feature you'd like:

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

@kafka1991 kafka1991 added the type/feature-request Categorizes issue or PR as related to a new feature. label Aug 4, 2024
@kafka1991 kafka1991 linked a pull request Aug 4, 2024 that will close this issue
13 tasks
@dveeden dveeden added type/compatibility compatibility-mysql80 This is a compatibility issue with MySQL 8.0(but NOT 5.7) labels Oct 23, 2024
@dveeden dveeden mentioned this issue Oct 23, 2024
70 tasks
@dveeden
Copy link
Contributor

dveeden commented Oct 23, 2024

I've added this to #7968 under "8.0.23"

@dveeden dveeden self-assigned this Jan 26, 2025
@dveeden
Copy link
Contributor

dveeden commented Jan 27, 2025

I think this is needed to be able to support this:

  • Define CLIENT_QUERY_ATTRIBUTES
  • Set CLIENT_QUERY_ATTRIBUTES in the Server Greeting
  • Handle COM_QUERY with query attributes
  • Handle COM_STMT_EXECUTE with query attributes
  • Create a mysql_query_attribute_string() function

Optional:

  • Use query attributes to set specific labels in metrics
  • Use query attributes to change configuration on a per-query basis
  • ...

@dveeden dveeden added the compatibility-mysql84 This is a compatibility issue with MySQL 8.4 label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility-mysql80 This is a compatibility issue with MySQL 8.0(but NOT 5.7) compatibility-mysql84 This is a compatibility issue with MySQL 8.4 component/mysql-protocol sig/sql-infra SIG: SQL Infra type/compatibility type/feature-request Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants