Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidb.toml change breaks backwards compatibility #9686

Closed
gregwebs opened this issue Mar 12, 2019 · 2 comments
Closed

tidb.toml change breaks backwards compatibility #9686

gregwebs opened this issue Mar 12, 2019 · 2 comments
Assignees

Comments

@gregwebs
Copy link
Contributor

The type of a configuration parameter was change in #9625

This breaks backwards compatibility. For example, tidb-operator no longer works with the latest TiDB.
The request is to establish a technique for making type changes in the toml that are backwards compatible.
The usual approaches would be

  1. Parse into multiple different types (either a string or a boolean). This is often supported for YAML, but I am not sure about doing this in TOML with go.
  2. Use a new key name for the new type (I am having trouble coming up with a good name) and support the old key type
@WangXiangUSTC
Copy link
Contributor

pr #9688 fix it

@morgo
Copy link
Contributor

morgo commented Mar 14, 2019

The PR referenced has been closed, so I am going to close this issue now. Please feel free to reopen it if you have any further questions. Thanks!

@morgo morgo closed this as completed Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants