Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: update the plan cache strategy when expressions with parameters affect null-check (#40218) #42637

Merged
merged 6 commits into from
Mar 28, 2023
Merged

planner: update the plan cache strategy when expressions with parameters affect null-check (#40218) #42637

merged 6 commits into from
Mar 28, 2023

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Mar 28, 2023 •
edited
Loading

This is an automated cherry-pick of #40218

What problem does this PR solve?

Issue Number: close #38205

Problem Summary: planner: update the plan cache strategy when expressions with parameters affect null-check

What is changed and how it works?

When expressions with parameters affect null-check, process null-check and skip plan-cache instead of skipping the null-check and caching a sub-optimal plan.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 28, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • chrysan
  • xuyifangreeneyes

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 28, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 28, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 28, 2023
elsa0520
elsa0520 approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@elsa0520 elsa0520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@elsa0520: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

fixdb
fixdb approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@fixdb fixdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@AilinKid
Copy link
Contributor

/retest

1 similar comment
@fzzf678
Copy link
Contributor

fzzf678 commented Mar 28, 2023

/retest

@fzzf678
Copy link
Contributor

fzzf678 commented Mar 28, 2023

/run unit-test

@qw4990
Copy link
Contributor Author

qw4990 commented Mar 28, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 34017bd

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 28, 2023
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 28, 2023
@qw4990
Copy link
Contributor Author

qw4990 commented Mar 28, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 547dee9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 28, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Mar 28, 2023
@qw4990
Copy link
Contributor Author

qw4990 commented Mar 28, 2023

/merge

@ti-chi-bot ti-chi-bot merged commit c585770 into pingcap:release-5.4 Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elsa0520 elsa0520 elsa0520 approved these changes

@xuyifangreeneyes xuyifangreeneyes xuyifangreeneyes approved these changes

@chrysan chrysan chrysan approved these changes

@fixdb fixdb fixdb approved these changes

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@qw4990 @ti-chi-bot @AilinKid @fzzf678 @fixdb @chrysan @xuyifangreeneyes @elsa0520 @VelocityLight