Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Applying region snapshots optimization #1347

Closed
flowbehappy opened this issue Jan 13, 2021 · 3 comments
Closed

Applying region snapshots optimization #1347

flowbehappy opened this issue Jan 13, 2021 · 3 comments
Assignees
@flowbehappy
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@flowbehappy
Copy link
Contributor

https://docs.google.com/document/d/1kPIM8Q67wMUBchwym0Fxjp4mtHSaJLwbuuvfxZ8nn28/edit

  • Increase the snap-handle-pool-size setting can improve the speed of applying region snapshots.
  • Reduce the memory usage during applying region snapshots, from 3 copies to at most 2 copies.
  • Use multiple Blocks to store the data of region snapshots.
@flowbehappy flowbehappy added the type/enhancement The issue or PR belongs to an enhancement. label Jan 13, 2021
@flowbehappy flowbehappy self-assigned this Jan 13, 2021
@flowbehappy flowbehappy mentioned this issue Jan 13, 2021
Closed
This was referenced Jan 26, 2021
Merged
Merged
@JaySon-Huang JaySon-Huang mentioned this issue Feb 19, 2021
Merged
@flowbehappy flowbehappy mentioned this issue Mar 22, 2021
Closed
@JaySon-Huang
Copy link
Contributor

Mark that this PR #1671 (this commit solotzg/tikv@5a8ab38 in particular), limit that when the number of pending snapshots is more than pool size, hold region-worker thread and do not pre-handle other snapshots.

@ti-srebot ti-srebot mentioned this issue May 7, 2021
Merged
@JaySon-Huang
Copy link
Contributor

Related bug: #1864

@JaySon-Huang
Copy link
Contributor

Have been merged to master and release-5.0. Will release on 5.0.2.

@JaySon-Huang JaySon-Huang mentioned this issue Jun 1, 2021
Closed
@JaySon-Huang JaySon-Huang mentioned this issue Jun 9, 2021
Closed
@JaySon-Huang JaySon-Huang mentioned this issue May 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flowbehappy flowbehappy

Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@flowbehappy @JaySon-Huang