Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The store size reported to PD is not correct #1836

Closed
JaySon-Huang opened this issue Apr 28, 2021 · 0 comments · Fixed by #1843
Closed

The store size reported to PD is not correct #1836

JaySon-Huang opened this issue Apr 28, 2021 · 0 comments · Fixed by #1843
Assignees
@JinheLin
Labels
severity/major type/bug The issue is confirmed as a bug.

Comments

@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Apr 28, 2021 •
edited
Loading

Introduced by #1751.
Steps to reproduce:

  1. Load a TPC-H dataset into TiFlash
  2. Restart the TiFlash process and don't do read / write on those tables
  3. Check the store size reported to PD, or "Store size" in the Grafana panel

image

Previously, we will restore the store size by calling DeltaMergeStore::restoreStableFiles in DelatMergeStore constructor. But now the store objects are Lazily initialized and not able to report the real store size.
This will make PD confused and cause lots of rebalancing between TiFlash nodes.
https://github.com/pingcap/tics/blob/65209cd0f7ffd330e9c5261231a64f2aa66cc28c/dbms/src/Storages/DeltaMerge/DeltaMergeStore.cpp#L1905-L1918
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JinheLin JinheLin

Labels
severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Init store in background task.
3 participants
@JaySon-Huang @JinheLin @lilinghai