Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sink/mysql(ticdc): rename syncpointStore.go to syncpoint_store.go #5506

Merged

Conversation

Rustin170506
Copy link
Member

What problem does this PR solve?

Issue Number: ref #5138

What is changed and how it works?

rename syncpointStore.go to syncpoint_store.go. It is not a standard naming.

Check List

Tests

  • No code

Questions

Will it cause performance regression or break compatibility?

No

Do you need to update user documentation, design documentation or monitoring documentation?

No

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 21, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CharlesCheung96

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 21, 2022
@Rustin170506 Rustin170506 added component/sink Sink component. area/ticdc Issues or PRs related to TiCDC. require-LGT1 Indicates that the PR requires an LGTM. labels May 21, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 21, 2022

Codecov Report

Merging #5506 (daf71d5) into master (e62fbea) will decrease coverage by 0.1736%.
The diff coverage is n/a.

Flag Coverage Δ
cdc 61.4772% <ø> (-0.0093%) ⬇️
dm 51.9500% <ø> (-0.0164%) ⬇️
engine ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #5506        +/-   ##
================================================
- Coverage   56.3160%   56.1423%   -0.1737%     
================================================
  Files           675        530       -145     
  Lines         78594      69965      -8629     
================================================
- Hits          44261      39280      -4981     
+ Misses        30143      26915      -3228     
+ Partials       4190       3770       -420     

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 22, 2022
@Rustin170506
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: daf71d5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 22, 2022
@ti-chi-bot ti-chi-bot merged commit ab968d8 into pingcap:master May 22, 2022
@Rustin170506 Rustin170506 deleted the rustin-patch-sink-mysql-syncpoint branch August 15, 2022 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. component/sink Sink component. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants