Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the config 'runAsDaemon' from tiflash.toml #1671

Closed
hehechen opened this issue Dec 14, 2021 · 0 comments
Closed

Remove the config 'runAsDaemon' from tiflash.toml #1671

hehechen opened this issue Dec 14, 2021 · 0 comments
Labels
type/feature-request Categorizes issue as related to a new feature.

Comments

@hehechen
Copy link
Contributor

Feature Request

pingcap/tiflash#3412
TiFlash has changed the default value of the config runAsDaemon to true, so tiup does not need to set the runAsDaemon in tiflash.toml after the TiFlash PR merged.

Why the featue is needed:
The configuration of runAsDaemon does not need to be perceived by the user, so it does not need to appear in tiflash.toml.

Describe alternatives you've considered:
Check the TiFlash version, remove the runAsDaemon config if TiFlash is in new version(>=v5.4.0).
@hehechen hehechen added the type/feature-request Categorizes issue as related to a new feature. label Dec 14, 2021
@hehechen hehechen mentioned this issue Dec 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/feature-request Categorizes issue as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hehechen