Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returning null instead of empty collection for SCIMAttribute #5

Open
jackychen-okta opened this issue Feb 27, 2016 · 5 comments
Open

Comments

@jackychen-okta
Copy link

Hi,

I notice that since a commit to fix the null strings, we return null instead of an empty collection. So if I do group.getMembers() on a GroupResource, it would be null and I can get a NPE on a foreach statement, e.g. for (Collection<Entry<String>> entry : group.getMembers()).

http://stackoverflow.com/questions/6077909/is-there-a-way-to-avoid-null-check-before-the-for-each-loop-iteration-starts

I can do a null check, but it seems extraneous to do that before a foreach.

@coulbeck
Copy link
Contributor

coulbeck commented Mar 3, 2016

You have a good point - it’s somewhat burdensome and not very friendly to return null. That said, we are unlikely to change the behavior because we are working on an entirely new SCIM v2 client library.

@asaf
Copy link

asaf commented Mar 7, 2016

@coulbeck out of the context of this issue, what's the state of the v2 client library ? is it going to be public under the same license, and if so, when?

Thank you for your great effort !

@coulbeck
Copy link
Contributor

coulbeck commented Mar 7, 2016

@asaf Currently it's planned to be public under the same license, sometime over summer (northern hemisphere!). Sorry I can't be any more specific right now.

@jwilleke
Copy link

So can the v2 client library work against PINGFederate? (Which appears to support SCIM v1.1)

@richardcardona
Copy link
Contributor

No, the SCIM 2 standard is not backward-compatible with SCIM 1.x hence two different libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants