Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live reload doesn't work with type="module" scripts #61

Closed
davej opened this issue Oct 27, 2017 · 2 comments
Closed

Live reload doesn't work with type="module" scripts #61

davej opened this issue Oct 27, 2017 · 2 comments
Labels
Milestone

Comments

@davej
Copy link
Member

davej commented Oct 27, 2017

When using:

<script type="module" src="module.js"></script>

The only snag seems to be that changes to .js files other than the main one don't trigger a livereload event.

#13 (comment)

@davej davej added the bug label Oct 27, 2017
@davej davej added this to the pre-v1.0 milestone Oct 27, 2017
@davej
Copy link
Member Author

davej commented Oct 27, 2017

This will depend on figuring out if there's a simple way to get dependent child modules.

@davej davej closed this as completed in 41878d4 Oct 29, 2017
@davej
Copy link
Member Author

davej commented Oct 29, 2017

Implementation isn't technically correct. Basically if the client page has a script[type=module] then it will always do a reload when any included js file has changed. This potentially could cause reloads even though the script isn't being loaded by that page.

Anyway, it'll do for now until there is a way to get all child scripts of a module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant