-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option for periodic flush #193
Comments
Actually... Why is anything getting buffered in the first place when I use this via |
Probably due to this pinojs/pino#1801 |
Anyhow I think that this is only relevant with |
Thanks for reporting! Would you like to send a Pull Request to address this issue? Remember to add unit tests. |
+1. Using set/clearInterval and calling .flush() seems to work for now. |
I think that's easy enough and it does not required any special handling to prevent leaking. Would you like to send a PR to document it in the docs? |
Flush will throw an error if |
When used for logging there could be cases of quiet periods where some log messages are buffered, but otherwise not yet flushed as they haven't filled the buffer yet. It would be helpful if sonic-boom would flush such messages after enough time passed without any new messages getting written so as you can still see what's the latest thing that has been logged in such cases without having to turn on
sync
mode.The text was updated successfully, but these errors were encountered: