[Question] Each handle cal calls get_all_env for two settings can be moved in init phase and stored in state..

[linearregression]

For every subscribe call it is calling application:gen_all_env..., though I suspect subscribe call is not that frequent.

Would moving get_all_env to init phase and store in state be better?
How about getting the config settings before starting the worker. If getting settings error-ed out(I assume that is essential info for worker to work), supervisor then does not need to start worker then restart etc.

File: elixometer/lib/elixometer.ex

 def handle_call({:subscribe, name}, _caller, state) do
      cfg = Application.get_all_env(:elixometer) <-----
      reporter = cfg[:reporter]   # <--- looks like this is relatively constant
      interval = cfg[:update_frequency]  # <--  looks like this is relatively constant

[scohen]

We could probably do something even smarter, like doing that during compile and binding it into a module attribute.

[zachdaniel]

@scohen you don't want to do that, because then people using releases won't be able to use environment variables to change this configuration.

[zorbash]

What about benchmarking it, to find out if it's worth optimising it?